bertcarnell / tornado

tornado plots for model sensitivity analysis
https://bertcarnell.github.io/tornado/
GNU General Public License v3.0
5 stars 0 forks source link

Update website config + add to DESCRIPTION #10

Closed olivroy closed 7 months ago

olivroy commented 7 months ago

You may consider also auto deployment of your website with usethis::use_pkgdown_github_pages().

You can also add the link to the website on the homepage of the repo in the About section. image

bertcarnell commented 7 months ago

Thanks for the suggestions, I appreciate the suggestions to add other links to the website. A couple of questions: (1) are you a user of the tornado package, or was there some other reason you wanted to make these changes? (2) Are there any reasons besides style and preference to make these changes? Was anything wrong with the original code?

olivroy commented 7 months ago

Hi Rob, thanks for the questions.

(1) are you a user of the tornado package, or was there some other reason you wanted to make these changes?

Currently, I do not use tornado, but I thought it was interesting, since I work with survival model and was looking for new tools. I am scanning CRAN to make cool discoveries. so that is the reason I wanted to make those changes, to make its documentation shine a little bit!

(2) Are there any reasons besides style and preference to make these changes? Was anything wrong with the original code?

Happy to answer other questions you may have!

bertcarnell commented 7 months ago

Thanks for those comments and your reasoning. I'll be incorporating most of these.