search

bertcarnell / tornado

tornado plots for model sensitivity analysis
https://bertcarnell.github.io/tornado/
GNU General Public License v3.0
5 stars 0 forks source link

Select single legend #8

Closed teunbrand closed 8 months ago

teunbrand commented 8 months ago

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break tornado.

In the new version, a plot can have multiple legend guide boxes, so the extracton method in the importance plot no longer works. This PR updates the function to deal with multiple legends, selecting the first that isn't empty.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this PR might help tornado get out a fix if necessary.

bertcarnell commented 8 months ago

I can confirm the error in using the suggested ggplot2 git version