Hot reload from Components - Not Working ....

bertho-zero / react-redux-universal-hot-example

A starter boilerplate for a universal webapp using react, redux, express and feathers

https://react-hot-example.herokuapp.com/

MIT License

636 stars 171 forks source link

Hot reload from Components - Not Working .... #534

Open Asher978 opened 5 years ago

Asher978 commented 5 years ago

After a fresh install of this repo and running in dev ...

encountered that the Hot reload is not functioning properly. For example if I change something in LoginForm and save, I see the below in my console.

usage of LoginForm:

// in Login.js (container)
import LoginForm from 'components/LoginForm/LoginForm';

// in routes.js
import Login from 'containers/Login/Loadable';

Any Suggestions?

bblurock commented 5 years ago

From what I understand, this is the correct behavior. When rebuilding, WebSocket connection will experience a short downtime.

Also this duplicate with #533

bertho-zero commented 5 years ago

This is the normal behavior, the server restarts and the connection is lost for a short time.

Asher978 commented 5 years ago

From what I understand, this is the correct behavior. When rebuilding, WebSocket connection will experience a short downtime.

Also this duplicate with #533

This isn't a duplicate. This issue was related to hot reloading not working properly from components. The duplicate you referred to #533 is related to sockets connection.

This issue is still unanswered and I would like the issue to be opened again.

chiragprodsmiths commented 5 years ago

Hi @bertho-zero ,

Thanks for this repo but hot reload is frustrating it doesn't work. any updates on the same

bertho-zero commented 5 years ago

I am not very available at the moment but I am open to any PR, do not hesitate to investigate.

chiragprodsmiths commented 5 years ago

I am not very available at the moment but I am open to any PR, do not hesitate to investigate.

Sure. Thanks