search

berthubert / simplomon

Very simple monitoring system with a single configuration file
MIT License
97 stars 12 forks source link

ntfy notifier doesn't have params for url and authentication #13

Closed arjan-s closed 3 months ago

arjan-s commented 3 months ago

I'm running my own ntfy instance which is password protected via HTTP Basic Authentication (see https://docs.ntfy.sh/publish/#authentication). It would be great if you could add params for the url and authentication so one can use private ntfy instances.

job commented 3 months ago

@arjan-s can you try this patch to see if that makes things work with your own instance of Ntfy?

https://github.com/job/simplomon/commit/636283559c8415090eff8c492a48b49eb835f169

I don't use Ntfy myself, but it compiles!

arjan-s commented 3 months ago

Almost, thanks! I left 3 required fixes in comments on that commit, with those fixes it works as expected!

berthubert commented 3 months ago

I think this has been addressed? all good now?

arjan-s commented 3 months ago

Yes, works like a charm!