search

berthubert / simplomon

Very simple monitoring system with a single configuration file
MIT License
119 stars 15 forks source link

Make OpenSSL requirement explicit in meson.build #43

Closed wandernauta closed 5 months ago

wandernauta commented 5 months ago

We require OpenSSL 3 because mailmon.cc calls SSL_get0_peer_certificate which does not exist in older versions.

job commented 5 months ago

Instead of specifically requiring OpenSSL 3, the code can also be adapted to use a more widely available variant of the function: https://github.com/berthubert/simplomon/commit/1c99319f0102fa52e05768aef4c73ffbb5c2523c (not really tested).

In general I'd avoid depending on OpenSSL 3 API, supporting a broader range of libcrypto versions helps with porting.

job commented 5 months ago

Today I learned about shared_ptr<>! Thanks :-)