search

berthubert / trifecta

educational image sharing website built on a combination of modern C++, web and database technologies
MIT License
149 stars 9 forks source link

feat: multi-stage docker build #29

Closed Lewiscowles1986 closed 10 months ago

Lewiscowles1986 commented 10 months ago

This makes the docker self-contained, should someone want to, or not know how to follow the instructions in the README.

This will also keep a machine clean; although further work could (and should) be done to ensure builds are fully reproducible.

Habbie commented 10 months ago

This makes the docker self-contained, should someone want to, or not know how to follow the instructions in the README.

Yes, excellent idea!

However, this builds a dynamically linked trifecta, but does not ship the libs (which means the image is not runnable). The current Docker build instructions (in README) build a static one.