The return value has to be initialized to false and set to true only when successful

bertmelis / espMqttClient

MQTT 3.1.1 client library for the Espressif devices ESP8266 and ESP32 on the Arduino framework.

https://www.emelis.net/espMqttClient/

MIT License

92 stars 21 forks source link

The return value has to be initialized to false and set to true only when successful #104

Closed tbnobody closed 12 months ago

tbnobody commented 1 year ago

Not sure if you like this PR as it breaks the current behavior of the connect method. If the _state is unequal disconnected now, the return value is false. Previously it was true. (Please see #102)

bertmelis commented 1 year ago

Although it is a breaking change, the old behaviour was actually not intended. So I'll happily merge.