search

bertmelis / espMqttClient

MQTT 3.1.1 client library for the Espressif devices ESP8266 and ESP32 on the Arduino framework.
https://www.emelis.net/espMqttClient/
MIT License
100 stars 21 forks source link

import lib #47

Closed podaen closed 1 year ago

podaen commented 1 year ago

I looked in to the library.properties file and I see there is no top header file reference includes=*.h for importing libs.

bertmelis commented 1 year ago

Because it's an optional property. Does it break something?

bertmelis commented 1 year ago

Unless it has a clear advantage to include this, this is not an issue.

podaen commented 1 year ago

The problems got away, but still it's not a best way to make a library for arduino. Better to make a a header file where you redirect to the things you need with if defined in a config file (for including perpeces) and that choise what you class you want to use.