search

bertoldia / files-menu

Quickly navigate your file system and open files through a menu.
GNU General Public License v3.0
1 stars 2 forks source link

localization support, German (de) translation #1

Closed jonnius closed 8 years ago

bertoldia commented 9 years ago

Hey Jonnius,

I'm assuming you can speak English :) Thanks for the patch! I've made one small change to it: https://github.com/bertoldia/files-menu/commit/6266095d31483d2674963bc7d1ce16d9853941dc in a branch named jonnius-master.

Could you please test that it doesn't break your changes? If it works I'll merge it asap.

Danke! axel.

On Fri, Jan 23, 2015 at 1:58 PM, jonnius notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/bertoldia/files-menu/pull/1 Commit Summary

  • localization support, German (de) translation

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/bertoldia/files-menu/pull/1.

jonnius commented 9 years ago

It didn't work with your changes. I guess by the moment the vars are beeing initialized, gettext is not. So you need the _(·) on every use of the vars. The initialization of the vars should still be in those brakets, too, so that the pot file could be created... I used you commit and fixed it.

bertoldia commented 9 years ago

Aw nuts. Thanks a lot gettext. Will look at this again soon.

On Sat, Jan 24, 2015 at 2:39 AM, jonnius notifications@github.com wrote:

It didn't work with your changes. I guess by the moment the vars are beeing initialized, gettext is not. So you need the _(·) on every use of the vars. The initialization of the vars should still be in those brakets, too, so that the pot file could be created...

— Reply to this email directly or view it on GitHub https://github.com/bertoldia/files-menu/pull/1#issuecomment-71307561.

bertoldia commented 9 years ago

How about this? I've kept the constants but do the gettext lookups at the call sites.

axel.

On Mon, Feb 2, 2015 at 10:04 PM, Axel von Bertoldi bertoldia@gmail.com wrote:

Aw nuts. Thanks a lot gettext. Will look at this again soon.

On Sat, Jan 24, 2015 at 2:39 AM, jonnius notifications@github.com wrote:

It didn't work with your changes. I guess by the moment the vars are beeing initialized, gettext is not. So you need the _(·) on every use of the vars. The initialization of the vars should still be in those brakets, too, so that the pot file could be created...

— Reply to this email directly or view it on GitHub https://github.com/bertoldia/files-menu/pull/1#issuecomment-71307561.

jonnius commented 9 years ago

Where to find your changes? You can try yourself restarting GNOME Shell in German with the command LANG=de_DE.utf8 gnome-shell --replace

bertoldia commented 8 years ago

Hi Jonnius, is this fixed in the current master?