bertozzivill / map-itn-cube

Geospatial insecticide-treated net models for the Malaria Atlas Project
GNU General Public License v3.0
0 stars 2 forks source link

Refactor out in-/output paths and create cli #217

Closed mauricio-tki closed 3 years ago

mauricio-tki commented 3 years ago

The advantages of these changes are that:

The following changes were made in scripts 3, 5, and 6

The changes retain backwards compatibility in that the same default values are still used when running the scripts without arguments. The in- and output directories can also still be manipulated using the previously used environment variables.

The only place where I had to break this was in script 3, where country, sensitivity_type and sensitivity_survey_count are now named arguments instead of postional ones. So instead of Rscript 03_stock_and_flow.r ERI, you must use Rscript 03_stock_and_flow.r --country ERI. Similarly, --sensitivity_type and --sensitivity_survey_count are used for the other two.

Let me know if you have any concerns. If not, I'll make similar changes to the ITN cube scripts that are run on GCP.

bertozzivill commented 3 years ago

This looks fantastic to me, so much clearer than before! Thanks for your work Mauricio.