search

bertramdev / asset-pipeline

The core implementation of the asset pipeline for the jvm
194 stars 92 forks source link

Excluding JS Files from minification results in non usable files within page #192

Closed dtamm closed 6 years ago

dtamm commented 6 years ago

Using the 

grails.assets.excludes = ["**/*Spec.js"]

option will result

<asset:javascript src="path\for\file\unitSpec.js" />

in 

<script type="text/javascript" src="/grails-application-name/assets/path/to/file/unitSpec.js" ></script>

which seems to be a non existing or empty file.

Excluding these files would mean to me, that i exclude them from minification but i could still use them on the page, or am i wrong here?

Using asset-pipeline version 2.14.1 on Grails 2.5.4.

davydotcom commented 6 years ago

no you are excluding them from inclusion and processing entirely. typically you do this for all files but application.js and register your requires in a "manifest" js file.

dtamm commented 6 years ago

Wow, that has been a pretty damn lag till the answer... ok got it!

davydotcom commented 6 years ago

Yea it got hidden in the issues list , sorry about that. Eyes kept not seeing it

On Jul 26, 2018, at 9:32 AM, Dominik Tamm notifications@github.com wrote:

Wow, that has been a pretty damn lag till the answer... ok got it!

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/bertramdev/asset-pipeline/issues/192#issuecomment-408117783, or mute the thread https://github.com/notifications/unsubscribe-auth/AABaEtEe8Y2Xy5MsDHgvAZE0Pg6C2GK9ks5uKdMMgaJpZM4RNktd.