bertramdev / asset-pipeline

The core implementation of the asset pipeline for the jvm
194 stars 92 forks source link

Fail build when assetCompile fails #196

Closed erichelgeson closed 6 years ago

erichelgeson commented 6 years ago

asset-pipeline should fail the build if :assetCompile has an error.

For example I accidentally used a ES6 feature in ES5 mode. It produced an empty file but did not fail the build so it went unnoticed.

notifications.unminified.js:2: ERROR - this language feature is only supported for ECMASCRIPT6 mode or better: const declaration. Use --language_in=ECMASCRIPT6 or ECMASCRIPT6_STRICT to enable ES6 features.
    const timeoutMs = 30000;
    ^
1 error(s), 0 warning(s)

Grails 3.3.x AP 2.14.6

makfair commented 6 years ago

Hi, There was a similar issue reported here which was closed, from the comment on close looks like not a proper response. Anything can be done to resolve this issue? https://github.com/bertramdev/asset-pipeline/issues/101

davydotcom commented 6 years ago

Seems to be related to the ExecutorService not capturing the Exceptions… looking into it

On Mar 21, 2018, at 6:27 AM, makfair notifications@github.com wrote:

Hi, There was a similar issue reported here which was closed, from the comment on close looks like not a proper response. Anything can be done to resolve this issue?

101 https://github.com/bertramdev/asset-pipeline/issues/101

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bertramdev/asset-pipeline/issues/196#issuecomment-374906411, or mute the thread https://github.com/notifications/unsubscribe-auth/AABaEnWBuL9cmRcrePaMgygW5Mtjd5DDks5tgjkbgaJpZM4SaTS7.

davydotcom commented 6 years ago

Fixed in soon to be released 3.0.2

pelenthium commented 5 years ago

Hi, does anyone know about this issue? 3.0.6 don't break the build if assetCompile have errors