search

bertramdev / asset-pipeline

The core implementation of the asset pipeline for the jvm
194 stars 92 forks source link

update closure-compiler-unshaded #203

Closed zyro23 closed 6 years ago

zyro23 commented 6 years ago

manually enforcing v20180402 with asset-pipeline-2.14.10 (gradle) seems to work fine for me. needed this to avoid some "unknown variable" $$$0 error during minification (uglyfication).

zyro23 commented 6 years ago

update: by trial and error, i found that v20170521 seems to be the last version working properly (i.e. fixes "unknown variable" $$$0).

unfortunately, newer versions (v20170626 and up) do not produce any js files as output. maybe related to a closure-compilter api change or sth.? ref. https://github.com/google/closure-compiler/wiki/Releases

zyro23 commented 6 years ago

now tried with 3.0.0 and v20180506 and took a look at the code. i guess the problem is the LanguageMode mapping:

n.b. seems 3.0.0 is released but not tagged yet.

davydotcom commented 6 years ago

closure is missing some pluggable ES2017 resolver stuff so they have to fix that before we can upgrade it... we switched to babel on a lot of stuff though so may be able to push on this.