search

bertramdev / asset-pipeline

The core implementation of the asset pipeline for the jvm
193 stars 91 forks source link

Grails config dot-notation warnings in 3.3.6 #285

Open robertoschwald opened 2 years ago

robertoschwald commented 2 years ago

There are still some statements left which use the deprecated dot notation to access config maps.

https://github.com/bertramdev/asset-pipeline/blob/master/asset-pipeline-grails/src/main/groovy/asset/pipeline/grails/AssetProcessorService.groovy#L104 (conf.url)

https://github.com/bertramdev/asset-pipeline/blob/master/asset-pipeline-grails/grails-app/taglib/asset/pipeline/grails/AssetsTagLib.groovy#L84 (conf.bundle)

This lead to warnings in Grails 5.0.0

Accessing config through dot notation is deprecated, and it will be removed in a future release. Use 'config.getProperty(key, targetClass)' instead.

davydotcom commented 2 years ago

So the second one is grabbing off the getProperty Map so this is ok