search

bertramdev / karman-core

Karman Groovy Library
8 stars 7 forks source link

Support Instance Profile Credentials for S3 Provider #9

Closed joemccall86 closed 5 years ago

joemccall86 commented 7 years ago

We're looking to replace our custom solution with karman, but the current plugin seems to require IAM credentials in code. AWS supports reading the credentials from the instance profile associated with the EC2 instance.

Basically if you use an instance of DefaultAWSCredentialsProviderChain as the AWSCredentialsProvider it will support credentials from the following locations:

Logging it here as a bug, but I'll be filing a PR for this as well. I plan to keep the existing strategy, and use the DefaultAWSCredentialsProviderChain as a fall-back option when the credentials are not found in code.

davydotcom commented 7 years ago

A PR for this would be most welcome thanks!

Sent from my iPhone

On Mar 13, 2017, at 5:37 PM, Joe McCall notifications@github.com wrote:

We're looking to replace our custom solution with karman, but the current plugin seems to require IAM credentials in code. AWS supports reading the credentials from the instance profile associated with the EC2 instance.

Basically if you use an instance of DefaultAWSCredentialsProviderChain as the AWSCredentialsProvider it will support credentials from the following locations:

Environment Variables System Properties ~/.aws/credentials Instance Profile of the launched EC2 instance Logging it here as a bug, but I'll be filing a PR for this as well. I plan to keep the existing strategy, and use the DefaultAWSCredentialsProviderChain as a fall-back option when the credentials are not found in code.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

joemccall86 commented 5 years ago

I think this issue can be closed.