bertrandmartel / javacard-gradle-plugin

:key: Gradle plugin for JavaCard development
MIT License
32 stars 14 forks source link

More flexible JcardSim configuration #2

Closed ph4r05 closed 6 years ago

ph4r05 commented 6 years ago

Hi! Thanks for this awesome gradle plugin!

I've been working with it for a while and I find useful to be able to change the JcardSim dependency included in the tests.

This PR adds few options to the extension.configuration

Namely:

With this I can disable the repo being added or include different version of the JCardSim.

Please take a look and let me know if this is OK for you. Thanks!

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.9%) to 87.719% when pulling fe1d216a07c6cb17b1b53e54f9437c98f60d6232 on ph4r05:jcardsim-modif into 37c133cb8a59feb46556412017c58b4d925c0faf on bertrandmartel:master.

bertrandmartel commented 6 years ago

Thanks a lot for this, I've added ability to extract test configuration like this :

test {
    dependencies {
        compile 'junit:junit:4.12'
        compile 'com.licel:jcardsim:3.0.4'
    }
}

So you can manage your own dependencies without relying on the plugin to do that. When at least one dependencies is specified, jcardsim repo is not included & jcardsim/junit are not default included in the plugin. I think this way it makes it more clear what is used in your project.

What do you think about this ? Does it cover your initial needs ?

ph4r05 commented 6 years ago

Hi! Perfect, this will do it as well.