search

bertrandmartel / speed-test-lib

:cloud: JSpeedTest : speed test client library for Java/Android
MIT License
381 stars 119 forks source link

Division by zero #30

Closed DimaDDM closed 7 years ago

DimaDDM commented 7 years ago

When i'm trying upload file to ftp server(using startUpload, not startUploadFTP) app crash with

java.lang.ArithmeticException: Division by zero at java.math.BigDecimal.divide(BigDecimal.java:1065) at fr.bmartel.speedtest.SpeedTestTask.getReport(SpeedTestTask.java:774) at fr.bmartel.speedtest.SpeedTestSocket.getLiveDownloadReport(SpeedTestSocket.java:678) at fr.bmartel.speedtest.SpeedTestTask.startSocketDownloadTask(SpeedTestTask.java:484) at fr.bmartel.speedtest.SpeedTestTask.access$1300(SpeedTestTask.java:57) at fr.bmartel.speedtest.SpeedTestTask$2.run(SpeedTestTask.java:409) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569) at java.lang.Thread.run(Thread.java:856)

bertrandmartel commented 7 years ago

What kind of FTP server are you using ? I tried with : 

final String fileName = SpeedTestUtils.generateFileName() + ".txt";
speedTestSocket.startUpload("speedtest.tele2.net", "/upload/" + fileName, 1000000);

which will end up with 404 status code as expected but no crash

bertrandmartel commented 7 years ago

This has been fixed in 1.30 thank you for you feedback :)