search

bertrandmartel / speed-test-lib

:cloud: JSpeedTest : speed test client library for Java/Android
MIT License
381 stars 119 forks source link

where is the option to enter ftp connection with active or passive mode? #57

Closed sajid-verveba closed 6 years ago

sajid-verveba commented 6 years ago

Hi Team,

Really nice work with this lib, i just went through code base but didn't find any mode setup for ftp connection. How we can setup ACTIVE or PASSIVE mode for ftp?

Can someone point me out on that direction ?

Thanks sajid

bertrandmartel commented 6 years ago

Thanks for your feedback, passive mode is the default : https://github.com/bertrandmartel/speed-test-lib/blob/master/jspeedtest/src/main/java/fr/bmartel/speedtest/SpeedTestTask.java#L1092.

I could make it configurable to be able to set active mode with : https://commons.apache.org/proper/commons-net/apidocs/org/apache/commons/net/ftp/FTPClient.html#enterLocalActiveMode()

bertrandmartel commented 6 years ago

You can try out setFtpMode in 1.32.1 : https://github.com/bertrandmartel/speed-test-lib#ftp-mode

sajid-verveba commented 6 years ago

that's cool, thanks