search

bertrandmartel / speed-test-lib

:cloud: JSpeedTest : speed test client library for Java/Android
MIT License
381 stars 119 forks source link

More parameters to startDownload methods #58

Open sajid-verveba opened 6 years ago

sajid-verveba commented 6 years ago

Hi, Following changes done in code base SpeedTestConstant.java FTP_DEFAULT_USER, FTP_DEFAULT_PASSWORD - remove final keyword user name can set from methods.

SpeedTestSocket.java new method startDownload with more parameters like username, password, ftp time, interval time etc

ISpeedTestSocket,java method declaration..

sajid-verveba commented 6 years ago

why this pull request failing ???

bertrandmartel commented 6 years ago

At this time, you can put username/password in uri like speedTestSocket.startDownload("ftp://username:password@ftp.otenet.gr/test1Mb.db");, this way you don't have to guess all the method signatures (especially if you will add more parameter later and set default arguments for some of those).