Does this role support `read_only` share option?

bertvv / ansible-role-samba

Ansible role for managing Samba as a file server on RedHat- and Debian-based linux distros.

https://galaxy.ansible.com/bertvv/samba/

Other

190 stars 118 forks source link

Does this role support `read_only` share option? #75

Open platan opened 3 years ago

platan commented 3 years ago

read_only is used in an example https://github.com/bertvv/ansible-role-samba/blob/812643507e2cc5e119d8de5338762d8b4eecf156/README.md#L146 But it isn't on the list of share options. Actually read_only only appears in README: https://github.com/bertvv/ansible-role-samba/search?q=read_only. So does this role support read_only share option?

bertvv commented 2 years ago

The Samba configuration has two ways to configure write access to a share: read_only and writable. IIRC, I only implemented the writable-option.

As far as I'm concerned, it's clearer to write writable: true than read_only: false, since the latter is a double negation.

If it's in the documentation, though, I should check that out and make it more consistent.