search

berty / berty

Berty is a secure peer-to-peer messaging app that works with or without internet access, cellular data or trust in the network
https://berty.tech
Other
7.41k stars 378 forks source link

Account storage key is not removed during delete #3894

Open n0izn0iz opened 2 years ago

jefft0 commented 9 months ago

Need to find the key store on iOS. (Maybe look at js/ios/Berty/Sources/Bridge/KeystoreDriver.swift ?) Should also try to find the keystore on Android. (Maybe look at js/android/app/src/main/java/tech/berty/gobridge/KeystoreDriver.java ?)

jefft0 commented 8 months ago

On iOS, handleAppUninstallation calls clearSecureKeyStore(). How to check if this is used when the account is deleted? https://github.com/berty/berty/blob/b323168b99005c759f5db1231830ac827396578a/js/ios/Berty/Sources/Bridge/KeystoreDriver.swift#L47

On Android, where does it create the keystore? https://github.com/berty/berty/blob/b323168b99005c759f5db1231830ac827396578a/js/android/app/src/main/java/tech/berty/gobridge/KeystoreDriver.java#L40

jefft0 commented 8 months ago

We don't have enough info right now to understand how the key store is saving data using the OS features. Put in backlog until we have time to investigate.

n0izn0iz commented 8 months ago

I think this issue was about the key not being removed on account delete, not app removal

jefft0 commented 8 months ago

Thanks, @n0izn0iz! I updated the comment.