search

berty / go-ipfs-log

Go version of append-only log CRDT on IPFS
https://berty.tech
Apache License 2.0
86 stars 32 forks source link

feat: add json marshaler interface to log's entry interface #58

Closed gfanton closed 10 months ago

codecov[bot] commented 2 years ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (eb69a86) 68.87% compared to head (1efd55a) 68.80%. Report is 1 commits behind head on master.

Files Patch % Lines
entry/entry.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== - Coverage 68.87% 68.80% -0.08% ========================================== Files 23 23 Lines 1825 1827 +2 ========================================== Hits 1257 1257 - Misses 365 367 +2 Partials 203 203 ``` | [Flag](https://app.codecov.io/gh/berty/go-ipfs-log/pull/58/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/berty/go-ipfs-log/pull/58/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) | `68.80% <0.00%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jefft0 commented 11 months ago

@gfanton , these changes seem harmless, but are they being used anywhere?

jefft0 commented 11 months ago

@jefft0 to do a local replace and see if we can still compile dependant repos like weshnet and berty. Check if the changes in this PR force those repos to implement json marshalling.

jefft0 commented 11 months ago

I did a force push of of rebasing this PR to the latest master.

jefft0 commented 11 months ago

This repo is a dependency for go-orbit-db. I update its go.mod with a replace to use this PR. make test on go-orbit-db has a stack overflow error. See the attached log. error.txt

@gfanton said "Looks like a recursive json unmarshal. Will be hard to find".

jefft0 commented 11 months ago

I confirm that we can build go-orbit-db, weshnet and berty with a local go.mod replace for this PR. But still have the "stack overflow" error shown above.

jefft0 commented 11 months ago

@gfanton will ask if it's OK to merge this.

jefft0 commented 10 months ago

Closing. @gfanton says "doesn't think it will be useful anyways and can probably introduce some problems."