search

berty / go-orbit-db

Go version of P2P Database on IPFS
https://berty.tech
Apache License 2.0
403 stars 55 forks source link

fix: make new peer event stateful #105

Closed gfanton closed 5 months ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (37cbb42) into master (b99ebe6) will increase coverage by 0.16%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   63.18%   63.35%   +0.16%     
==========================================
  Files          35       35              
  Lines        2483     2483              
==========================================
+ Hits         1569     1573       +4     
+ Misses        630      627       -3     
+ Partials      284      283       -1
Flag Coverage Δ
unittests 63.35% <100.00%> (+0.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
baseorbitdb/orbitdb.go 67.84% <100.00%> (+0.66%) :arrow_up:
pubsub/oneonone/channel.go 71.42% <0.00%> (+1.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b99ebe6...37cbb42. Read the comment docs.

jefft0 commented 8 months ago

Asked gfanton if this is still relevant.

jefft0 commented 5 months ago

gfanton says "I don't think it has an impact. You can close it I think." Closing without merge.