berty / go-orbit-db

Go version of P2P Database on IPFS
https://berty.tech
Apache License 2.0
412 stars 56 forks source link

fix: close of stores #114

Closed D4ryl00 closed 1 year ago

D4ryl00 commented 2 years ago

This PR instroduces some BREAKING CHANGES and fix the close of stores.

codecov[bot] commented 2 years ago

Codecov Report

Base: 63.82% // Head: 62.82% // Decreases project coverage by -0.99% :warning:

Coverage data is based on head (d4c07a8) compared to base (b503985). Patch coverage: 65.16% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #114 +/- ## ========================================== - Coverage 63.82% 62.82% -1.00% ========================================== Files 36 35 -1 Lines 2485 2515 +30 ========================================== - Hits 1586 1580 -6 - Misses 620 643 +23 - Partials 279 292 +13 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `62.82% <65.16%> (-1.00%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/berty/go-orbit-db/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) | Coverage Δ | | |---|---|---| | [stores/basestore/base\_store.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2Jhc2VzdG9yZS9iYXNlX3N0b3JlLmdv) | `59.02% <59.20%> (-1.96%)` | :arrow_down: | | [baseorbitdb/orbitdb.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-YmFzZW9yYml0ZGIvb3JiaXRkYi5nbw==) | `71.20% <88.46%> (+2.99%)` | :arrow_up: | | [messagemarshaler/json\_marshaler.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-bWVzc2FnZW1hcnNoYWxlci9qc29uX21hcnNoYWxlci5nbw==) | `100.00% <100.00%> (ø)` | | | [pubsub/oneonone/channel.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-cHVic3ViL29uZW9ub25lL2NoYW5uZWwuZ28=) | `71.26% <100.00%> (-2.55%)` | :arrow_down: | | [pubsub/pubsubraw/pubsub.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-cHVic3ViL3B1YnN1YnJhdy9wdWJzdWIuZ28=) | `79.41% <100.00%> (+0.62%)` | :arrow_up: | | [stores/documentstore/document.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2RvY3VtZW50c3RvcmUvZG9jdW1lbnQuZ28=) | `46.21% <100.00%> (ø)` | | | [stores/eventlogstore/log.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2V2ZW50bG9nc3RvcmUvbG9nLmdv) | `69.38% <100.00%> (ø)` | | | [stores/events.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2V2ZW50cy5nbw==) | `100.00% <100.00%> (ø)` | | | [stores/kvstore/keyvalue.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2t2c3RvcmUva2V5dmFsdWUuZ28=) | `45.94% <100.00%> (ø)` | | | [pubsub/pubsubcoreapi/pubsub.go](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-cHVic3ViL3B1YnN1YmNvcmVhcGkvcHVic3ViLmdv) | `70.12% <0.00%> (-10.39%)` | :arrow_down: | | ... and [6 more](https://codecov.io/gh/berty/go-orbit-db/pull/114/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.19.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: