berty / go-orbit-db

Go version of P2P Database on IPFS
https://berty.tech
Apache License 2.0
403 stars 55 forks source link

fix: directChannel not working #119

Closed D4ryl00 closed 1 year ago

D4ryl00 commented 1 year ago

Roll back directChannel in orbitdb instance to avoid multiple instances of directChannel sharing the same protocolID.

Signed-off-by: D4ryl00 d4ryl00@gmail.com

codecov[bot] commented 1 year ago

Codecov Report

Base: 62.94% // Head: 62.88% // Decreases project coverage by -0.05% :warning:

Coverage data is based on head (3301a16) compared to base (3a5a22b). Patch coverage: 69.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #119 +/- ## ========================================== - Coverage 62.94% 62.88% -0.06% ========================================== Files 35 37 +2 Lines 2515 2541 +26 ========================================== + Hits 1583 1598 +15 - Misses 640 646 +6 - Partials 292 297 +5 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `62.88% <69.66%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/berty/go-orbit-db/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) | Coverage Δ | | |---|---|---| | [stores/events.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2V2ZW50cy5nbw==) | `100.00% <ø> (ø)` | | | [stores/basestore/base\_store.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2Jhc2VzdG9yZS9iYXNlX3N0b3JlLmdv) | `58.62% <50.00%> (-0.41%)` | :arrow_down: | | [baseorbitdb/orbitdb.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-YmFzZW9yYml0ZGIvb3JiaXRkYi5nbw==) | `71.12% <70.58%> (-0.08%)` | :arrow_down: | | [baseorbitdb/events\_handler.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-YmFzZW9yYml0ZGIvZXZlbnRzX2hhbmRsZXIuZ28=) | `71.42% <71.42%> (ø)` | | | [baseorbitdb/events.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-YmFzZW9yYml0ZGIvZXZlbnRzLmdv) | `100.00% <100.00%> (ø)` | | | [pubsub/directchannel/channel.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-cHVic3ViL2RpcmVjdGNoYW5uZWwvY2hhbm5lbC5nbw==) | `68.08% <100.00%> (+0.69%)` | :arrow_up: | | [stores/kvstore/index.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-c3RvcmVzL2t2c3RvcmUvaW5kZXguZ28=) | `82.60% <0.00%> (-8.70%)` | :arrow_down: | | [pubsub/oneonone/channel.go](https://codecov.io/gh/berty/go-orbit-db/pull/119/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-cHVic3ViL29uZW9ub25lL2NoYW5uZWwuZ28=) | `70.11% <0.00%> (-4.60%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 1.19.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: