berty / go-orbit-db

Go version of P2P Database on IPFS
https://berty.tech
Apache License 2.0
403 stars 55 forks source link

fix: increase DelimitedReadMaxSize for direct channel #131

Closed gfanton closed 1 year ago

gfanton commented 1 year ago

sending remote heads, made the head exchange fails if the addition of both remote and local heads exceed DelimitedReadMaxSize

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.28 :warning:

Comparison is base (abc7b33) 63.01% compared to head (62a3ff0) 62.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #131 +/- ## ========================================== - Coverage 63.01% 62.73% -0.28% ========================================== Files 37 37 Lines 2544 2544 ========================================== - Hits 1603 1596 -7 - Misses 645 649 +4 - Partials 296 299 +3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `62.73% <0.00%> (-0.28%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/berty/go-orbit-db/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) | Coverage Δ | | |---|---|---| | [pubsub/directchannel/channel.go](https://codecov.io/gh/berty/go-orbit-db/pull/131?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty#diff-cHVic3ViL2RpcmVjdGNoYW5uZWwvY2hhbm5lbC5nbw==) | `68.08% <0.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://codecov.io/gh/berty/go-orbit-db/pull/131/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=berty)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.