berty / www.berty.tech

Official website of Berty Technologies
https://berty.tech
MIT License
34 stars 52 forks source link

Get rid of Google AMP #315

Closed moul closed 8 months ago

moul commented 2 years ago

The idea is to keep the good practices that come with google AMP, but remove the trigger that forces to be 100% consistent + that says to google “hey, you can AMPize my website in your cache”

So, if I’m not wrong, just remove the :zap: from the HTML head, but it needs to be double-checked

Clearly, I don’t like being in the Google cache system, and I don’t like having warning because of the limitations introduced by AMP, but it’s by far, my current favorite good practice handbook in term of performances, and organization

hint: pretty sure that there are blogposts explaining how other people made the same thing

jefft0 commented 9 months ago

@iuricmp will take a look how the web site is using AMP and if we need it.

iuricmp commented 8 months ago

To remove Google AMP we need to replace all the amp components in favor of native ones.

I don't see any benefit in doing this right now. I vote to close this issue.

jefft0 commented 8 months ago

OK. If we keep AMP, what do you think about the related issue https://github.com/berty/www.berty.tech/issues/152 ?

iuricmp commented 8 months ago

It should be ok once the website doesn't have the #152 button anymore.

jefft0 commented 8 months ago

Will ask @moul if it's still relevant to remove AMP.

iuricmp commented 8 months ago

Closing this since it is not more relevant, according to the reporter.