fix the App link button

berty / www.berty.tech

Official website of Berty Technologies

https://berty.tech

MIT License

34 stars 52 forks source link

fix the App link button #365

Closed iuricmp closed 1 year ago

iuricmp commented 1 year ago

Describe a minimal setup to run Berty's website locally.
Fix for #4346: Currently, the button had no link address associated with it. This fix creates the link button to redirect the user to the app.
Fix the local build on arm64 by updating the "sharp" dependency. (ref https://github.com/lovell/sharp/issues/2460#issuecomment-784881420)

iuricmp commented 1 year ago

Why do you have all these changes in your package-lock.json ?

I forgot to add package.json. Added.

clegirar commented 1 year ago

Honestly i didn't work a lot on this repository, and the package-lock.json changes seems weird for me especially with just an upgrade of sharp library in the package.json

Why do you upgrade sharp library ? Do you need it to just add a link to the button ? If not i suggest to just don't upgrade anything and just do what your PR say 👍

But you can do as you want obviously 👍

iuricmp commented 1 year ago

Sure, I faced some issues during the project setup on Mac m1. It wasn't compiling correctly and one of the log issues was regarding the sharp lib. Ref: https://github.com/lovell/sharp/issues/2460#issuecomment-784881420 I'll add this info on the PR notes.

clegirar commented 1 year ago

Oh okay it's for the build on m1 👍 Yes please add a note to explain it correctly 👍

After that you can merge whenever you want 👍