beryx / badass-jlink-plugin

Create a custom runtime image of your modular application
https://badass-jlink-plugin.beryx.org
Apache License 2.0
385 stars 27 forks source link

Compatibility with jpackage+1-35 (29/8) #82

Closed nemphys closed 5 years ago

nemphys commented 5 years ago

Hello, you might want to take a look at the latest jpackage build, because I think something is broken.

It runs fine and produces a package (in macOS at least), but it seems as though the unix script template is ignored, since I have added some customisations there (-Duser.dir) that don't seem to be working.

siordache commented 5 years ago

Did it work with the previous jpackage build (jpackage+1-33)? How do you pass the -Duser.dir argument?

nemphys commented 5 years ago

Yes, it did (does). As for the -Duser.dir argument, I have just added it in my unix script template.

siordache commented 5 years ago

jpackage doesn't use the unix script. You should add -Duser.dir to jvmArgs:

jlink {
    launcher {
        jvmArgs = ['-Duser.dir=my/user/dir']
        ...
    }
    ...
}

or:

jlink {
    jpackage {
        jvmArgs = ['-Duser.dir=my/user/dir']
        ...
    }
    ...
}
nemphys commented 5 years ago

I used the unix script template because I need to set the user.dir to a path detected at runtime (which is not possible to do in build.gradle). It makes me wonder, though, since it works fine with the previous version of jpackage and breaks with the latest.

DJViking commented 5 years ago

The jpackage is still under development and might change. The latest build is almost a month old. https://jdk.java.net/jpackage/

If you have problems with jpackage I suggest you subscribe to the core-libs-dev@openjdk.java.net mailinglist. The developers are taking in feedback from the community, so it is still possible to influence the development of jpackage (to a degree). It is not a support mailinglist, but you can report problems and bugs you experience with jpackage.

nemphys commented 5 years ago

Just checked with the latest version of jpackage and this still applies. I am closing the issue, though, since the observed behaviour change not the plugin's fault.