search

beryx / badass-runtime-plugin

Create a custom runtime image of your non-modular application
https://badass-runtime-plugin.beryx.org
Apache License 2.0
162 stars 21 forks source link

runInBinDir and {{BIN_DIR}} are inconsistent #106

Open Vampire opened 3 years ago

Vampire commented 3 years ago

If you set runInBinDir to true, the start script does not actually cd into the bin dir, but to the place where the startscript is stored (which is good). But the {{BIN_DIR}} variable is replaced by $APP_HOME/bin or %APP_HOME%\\bin.

This is a bit inconsistent and actually the naming of runInBinDir is slightly off.

I don't know how to best solve this, as changing either would be a breaking change. Maybe it would be a good idea to deprecate runInBinDir and replace it by runInStartscriptDir or some better name or have a more flexible option that allows to configure where exactly the process is started.

Vampire commented 2 years ago

It's actually even worse and more inconsistent. The Windows start scripts run it within the start script containing directory. The Linux start script runs it within the BIN_DIR. O_O

satsen commented 2 years ago

@Vampire This plugin seems to have many issues and flaws and the maintainer seems to have gone quite inactive.. I don't think any problems will be fixed

siordache commented 2 years ago

@Vampire This plugin seems to have many issues and flaws and the maintainer seems to have gone quite inactive.. I don't think any problems will be fixed

Unfortunately, this is true. I no longer have time to properly maintain this plugin. Is anyone interested in becoming the new maintainer of this project? Just drop a line here or send me an email.