search

bes-dev / stable_diffusion.openvino

Apache License 2.0
1.53k stars 208 forks source link

add toml file and poetry.lock #32

Open koji opened 1 year ago

koji commented 1 year ago

Add 2 files and this will close #27

Poetry version 1.1.6

Usage

$ poetry install
$ poetry run python python_file
after-ephemera commented 1 year ago

Did you want to also remove the requirements.txt file to complete the transition and avoid having two sources of truth? It would probably also be nice to update the README to reflect the new preferred approach for installation.

koji commented 1 year ago

@jkjetty I think keeping requiremetns.txt is kind of good since that can give options. In addition, I'm not sure how popular poetry is, so that is the reason why I didn't add any information to the readme.

after-ephemera commented 1 year ago

@koji I will let the maintainer chime in here to make the final decision but I think poetry is well enough adopted in the community that it's worth dropping the requirements.txt file, even if that may mean some grace period of supporting both. Maintaining two declarations of dependencies over time is probably not a job any of us want to be doing.