search

besarthoxhaj / phoenix

React native project example
9 stars 1 forks source link

Route list is in two files #59

Open nikhilaravi opened 8 years ago

nikhilaravi commented 8 years ago

Route list is in two places _routes.js with header and footer config and also in utils/router.js with the authentication mode for each route.

It would be cleaner to declare all the options for each route in one file to make sure the routes are kept in sync and so both files don't need to be updated each time a new route is added.

nikhilaravi commented 8 years ago

P.s. really like how the routes have been structured in the routelist and how all the routes are containers - router.js is so much cleaner now! :)

besarthoxhaj commented 8 years ago

@nikhilaravi agree! The reason it was done in this way was to avoid polluting the environment with react-native presence.

Once I have been able to rewire it, I will move everything inside _routes.js

nikhilaravi commented 8 years ago

Also a new route needs to be added to the 'routes' array inside the router reducer.