search

bespoke-silicon-group / bsg_manycore

Tile based architecture designed for computing efficiency, scalability and generality
Other
230 stars 58 forks source link

Should only require dramsim3 with HBM tests #313

Open dpetrisko opened 4 years ago

dpetrisko commented 4 years ago 
[petrisko@kk9 bsg_manycore]$ make -C machines/ 4x4/simv
make: Entering directory '/mnt/users/ssd0/no_backup/petrisko/bsg_bladerunner/bsg_manycore/machines'
make: *** No rule to make target '/mnt/users/ssd0/no_backup/petrisko/bsg_bladerunner/bsg_manycore/../basejump_stl/imports/DRAMSim3/src/bankstate.cc', needed by '4x4/simv'.  Stop.
make: Leaving directory '/mnt/users/ssd0/no_backup/petrisko/bsg_bladerunner/bsg_manycore/machines'
[petrisko@kk9 bsg_manycore]$

The short-term fix here is to manually update the dramsim3 submodule. But otherwise options are: 1) Should update basejump to automatically point to public dramsim3 https://github.com/bespoke-silicon-group/basejump_stl/pull/269 2) Should automatically update dramsim3 as part of make checkout 3) Should not require dramsim3 for testbenches which don't need it

drichmond commented 4 years ago

@dpetrisko Is this fixed now, with the public Dramsim3 submodule?

dpetrisko commented 4 years ago

1/2 are fixed. 3 someone suggested when I opened the issue, I could go either way. Doesn't seem like a huge overhead to require dramsim3 always