bespoke-silicon-group / bsg_manycore

Tile based architecture designed for computing efficiency, scalability and generality
Other
225 stars 58 forks source link

vanilla core: valid EVA space for load reservation #35

Open tommydcjung opened 5 years ago

tommydcjung commented 5 years ago

LR.W should only makes a reservation on local DMEM address. (EVA 0x00~0x3ff).

store to this address breaks the reservation.

what happens if remote store and making reservation takes place at the same cycle?

taylor-bsg commented 5 years ago

On Sun, May 26, 2019 at 11:59 PM tommie notifications@github.com wrote:

LR.W should only makes a reservation on local DMEM address. (EVA 0x00~0x3ff).

It’s not totally non-sensical to support remote LR; but we don’t implement it yet. Maybe leave the issue open but put an warning assertion in the code that says it is not implemented?

What we probably will not ever support is load on broken reservation to a non-local address. Probably should add a warning assert for this one as well.

store to this address breaks the reservation.

what happens if remote store and making reservation takes place at the same cycle?

If LR and remote store occur on same cycle... well they both require access to the data ram, so they cannot technically happen on the same cycle. If the remote store happens after the LR, the reservation must be broken, otherwise a Load-on-broken reservation could stall indefinitely. If the remote store happens before the LR, then the LR will get the value stored by the remote store, and the reservation will be set. Does that correspond to what currently happens?

You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bespoke-silicon-group/bsg_manycore/issues/35?email_source=notifications&email_token=AEFG5AH5LJG7KYXWGXTMT5LPXOBFPA5CNFSM4HPZDWQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GV6SC3Q, or mute the thread https://github.com/notifications/unsubscribe-auth/AEFG5AEMDYW6JS7S7HT53CDPXOBFPANCNFSM4HPZDWQQ .

tommydcjung commented 5 years ago

It seems like LR can be broken only by remote store, if i understand correctly. @ShawnLess