search

bespoke-silicon-group / bsg_manycore

Tile based architecture designed for computing efficiency, scalability and generality
Other
214 stars 56 forks source link

Fnmadd/sub fix #684

Closed tommydcjung closed 1 year ago

tommydcjung commented 1 year ago

-Fixing fma ops that were swapped for fnmadd/fnmsub.

taylor-bsg commented 1 year ago

@dpetrisko

dpetrisko commented 1 year ago

Hi, I believe the previous behavior was correct (although the name is unintuitive as this ISA manual notes)

image

I think this is verified by the rv32uf-p-fmadd test here (which may fail now): https://github.com/bespoke-silicon-group/bsg_manycore/tree/d47c40d7d9ed16d0f448686147743e875dd5fa02/software/spmd/bsg_riscv_tests

tommydcjung commented 1 year ago

Never mind guys, got confused by the document.