search

bespoke-silicon-group / bsg_manycore

Tile based architecture designed for computing efficiency, scalability and generality
Other
214 stars 56 forks source link

Fix host module paths in saif dumper #686

Closed dpetrisko closed 1 year ago

dpetrisko commented 1 year ago

https://github.com/bespoke-silicon-group/bsg_manycore/blob/8b450d997095c84dbfe5a44b83c7ea00713025b3/testbenches/common/v/bsg_nonsynth_manycore_testbench.v#L168

This path broke as a result of this change: #652

dpetrisko commented 1 year ago

Would be nice to keep separate genvar names for halfruche and mesh, but it makes the binds much more complicated. I think fi1 is a good compromise

tommydcjung commented 1 year ago

Is it okay if the label names are duplicated? Can you fix the path for the vcache_profiler as well? https://github.com/bespoke-silicon-group/bsg_manycore/blob/master/testbenches/common/v/bsg_nonsynth_manycore_testbench.v#L923

dpetrisko commented 1 year ago

Yup, got vcache profiler as well. It's fine to have the same label for all branches of an if -- just can't have the same label for two separate ifs. The labels have to uniquely identify modules