1.
I notice that in examples/spmd/Makefile, we kind of assume that all the examples appearing in bsg_manycore would also exist in bsg_replicant. Would it be better if we can just search under bsg_replicant/examples/spmd/ so that if there are missing examples, we won't have "No such file or directory" error?
dpetrisko
commented
1 year ago
Hi I'm looking at this commit 6515c42
1. I notice that in examples/spmd/Makefile, we kind of assume that all the examples appearing in bsg_manycore would also exist in bsg_replicant. Would it be better if we can just search under bsg_replicant/examples/spmd/ so that if there are missing examples, we won't have "No such file or directory" error?
2. In libraries/bsg_manycore_features.h, we test if _BSD_SOURCE is defined. However, in newer glibc versions, _BSD_SOURCE is deprecated and is replaced by _DEFAULT_SOURCE according to https://stackoverflow.com/questions/29201515/what-does-d-default-source-do. Without the following changes I wouldn't be able to run make regression on Rocky 8.7, so perhaps we can update this as well.
If these changes make sense I can make a PR. Thanks!