search

bespokejs / bespoke-hash

Hash Routing for Bespoke.js
MIT License
15 stars 7 forks source link

Problem with... #2

Closed WideCircle closed 9 years ago

WideCircle commented 9 years ago

...with using data-bespoke-hash="title2" for example. Can't use "data-bespoke-hash" for my own titles. Browser crash...without "data-bespoke-hash" the numbered hashes work fine...

starandtina commented 9 years ago

Is any one could check this problem? I can't add two data-bespoke-hash and it will cause browser crash. I guess the problem is caused by this line of code. But I don't know why we need to iterate all the slides here.

WideCircle commented 9 years ago

Hi! I've removed these lines of code. It works navigating from a button but using back & forward buttons in the browser doesn't work & also deep linking isn't working correctly... There seems to be some sort of a looping problem here...

markdalgleish commented 9 years ago

I'm unable to reproduce this issue. Could you write a failing test case for this?

markdalgleish commented 9 years ago

I looked at this again today and realised what the issue is. I have a failing test case and I'm working on a fix.

markdalgleish commented 9 years ago

This has been fixed in v1.0.1 which has just been published to npm.

WideCircle commented 9 years ago

Super! Thank you so much Mark!