search

bespokejs / bespoke-hash

Hash Routing for Bespoke.js
MIT License
15 stars 7 forks source link

use id attribute as alternative to data-bespoke-hash #4

Closed mojavelinux closed 7 years ago

mojavelinux commented 8 years ago

As an alternative to the data-bespoke-hash attribute, this patch enables the bespoke-hash plugin to look at the id attribute on a slide.

If you don't want to activate this feature by default, I'd be okay to hide it behind an option (e.g., { byId: true }.

mojavelinux commented 8 years ago

@markdalgleish is there a reason I should know about that you decide to use the data-bespoke-hash attribute instead of the id attribute for named routing? Knowing that reason would help me understand if we need to make this an option.

mojavelinux commented 7 years ago

@hsablonniere could you merge this and make a new release?

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling d0c6ecaac9ddcfc94f34e76309129a44e26cb321 on mojavelinux:by-id into 1859435f0e43c36782ca389a9f058882049456c8 on bespokejs:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 669663373367328fa6a377edd3599283bcc71103 on mojavelinux:by-id into 1859435f0e43c36782ca389a9f058882049456c8 on bespokejs:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 669663373367328fa6a377edd3599283bcc71103 on mojavelinux:by-id into 1859435f0e43c36782ca389a9f058882049456c8 on bespokejs:master.

hsablonniere commented 7 years ago

@mojavelinux LGTM!

hsablonniere commented 7 years ago

Version here: https://github.com/bespokejs/bespoke-hash/releases/tag/v1.1.0