search

bespokejs / bespoke

DIY Presentation Micro-Framework
http://markdalgleish.com/projects/bespoke.js/
MIT License
4.68k stars 443 forks source link

step.bind() framework does not work on iOs5 #22

Closed synthview closed 11 years ago

synthview commented 11 years ago

Hello, I've read the this topic https://github.com/markdalgleish/bespoke.js/issues/2 where you say the issue is in the site not in the framework.

I’m using your original bespoke.js file and trying to add buttons to make the desk’s cards slide but on iOs5 bespoke.next(); breaks the js at step.bind() (into bespoke.js).

If you could fix it fast it would be great :) there are still many devices using iOs5… Thanks

markdalgleish commented 11 years ago

iOS5 is missing Function#bind, so a simple fix is to include es5-shim.

synthview commented 11 years ago

Thanks, I'm not a js ninja, is there a way to make only older webkit to load it?

synthview commented 11 years ago

or maybe use a jquery command, as I use jquery on the same page?

markdalgleish commented 11 years ago

Since you're already using jQuery, it wouldn't be a big deal to include the bind polyfill on its own for everyone.

synthview commented 11 years ago

well, I've tried to import es5-shim and after this, to add the the jquery bind polyfill code but none worked as now I see a new error in console: TypeError: Result of expression 'el.classList' [undefined] is not an object.

synthview commented 11 years ago

Ooops, sorry, it works on iOs5! It doesn't with Mac Safari 4, but who cares about that :)