search

bespoken / virtual-alexa

:robot: Easily test and debug Alexa skills programmatically
https://bespoken.io
Apache License 2.0
112 stars 35 forks source link

ISP response request #121

Closed jkelvie closed 4 years ago

jkelvie commented 4 years ago

Created helper method for creating Connections Response and ISP Connection Responses in particular

codecov[bot] commented 4 years ago

Codecov Report

Merging #121 into master will increase coverage by 0.07%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   92.79%   92.86%   +0.07%     
==========================================
  Files          25       25              
  Lines        1207     1219      +12     
  Branches      173      176       +3     
==========================================
+ Hits         1120     1132      +12     
  Misses         87       87

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c429223...49c9ec2. Read the comment docs.

jkelvie commented 4 years ago

First cut of PR based on your work @rmtuckerphx - pretty close to what you had but I left out the enums. They are helpful, but they don't fit cleanly with what we have done to date (we need some sort of Constants class perhaps).

Take a look when you have a chance.

jkelvie commented 4 years ago

@jperata This is ready to go