search

bespoken / virtual-alexa

:robot: Easily test and debug Alexa skills programmatically
https://bespoken.io
Apache License 2.0
112 stars 35 forks source link

Adds AMAZON.LITERAL / AMAZON.SearchQuery built-in types #67

Closed cnadeau closed 5 years ago

cnadeau commented 6 years ago

Fixes Issue #66 : Adds AMAZON.LITERAL / AMAZON.SearchQuery built-in type

https://github.com/bespoken/virtual-alexa/issues/66

codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@a3cbbb1). Click here to learn what that means. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #67   +/-   ##
=========================================
  Coverage          ?   95.12%           
=========================================
  Files             ?       27           
  Lines             ?     1231           
  Branches          ?      169           
=========================================
  Hits              ?     1171           
  Misses            ?       60           
  Partials          ?        0
Impacted Files Coverage Δ
src/model/BuiltinSlotTypes.ts 97.61% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a3cbbb1...03a2e19. Read the comment docs.

cnadeau commented 6 years ago

@jkelvie no worries :-) (continuing discussion from https://github.com/bespoken/virtual-alexa/issues/66#issuecomment-397465134)

The parsing makes sense, it's just that the intent schema parsing failed and crashed when an unhandled type is provided. Adding those 2 covered my use cases for now.