search

bespoken / virtual-alexa

:robot: Easily test and debug Alexa skills programmatically
https://bespoken.io
Apache License 2.0
112 stars 35 forks source link

Better error message when dialog slot type is not matched #76

Closed jkelvie closed 6 years ago

jkelvie commented 6 years ago

Based on this interaction in intercom, identified spot for better error-handling:

Cannot read property 'match' of undefined

TypeError: Cannot read property 'match' of undefined

at DialogManager.Object.<anonymous>.DialogManager.handleUtterance (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/node_modules/virtual-alexa/lib/src/dialog/DialogManager.js:84:38)

at LocalSkillInteractor.Object.<anonymous>.SkillInteractor.spoken (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/node_modules/virtual-alexa/lib/src/impl/SkillInteractor.js:60:53)

at VirtualAlexa.Object.<anonymous>.VirtualAlexa.utter (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/node_modules/virtual-alexa/lib/src/core/VirtualAlexa.js:53:33)

at VirtualAlexaInvoker.<anonymous> (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/VirtualAlexaInvoker.js:118:61)

at step (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/VirtualAlexaInvoker.js:3:191)

at ../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/VirtualAlexaInvoker.js:3:437

at VirtualAlexaInvoker.<anonymous> (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/VirtualAlexaInvoker.js:3:99)

at VirtualAlexaInvoker.invoke (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/VirtualAlexaInvoker.js:125:30)

at TestRunner.<anonymous> (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/TestRunner.js:143:50)

at step (../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/TestRunner.js:3:191)

at ../.npm-global/lib/node_modules/bespoken-tools/node_modules/skill-testing-ml/dist/lib/runner/TestRunner.js:3:361
codecov[bot] commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1197c3d). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #76   +/-   ##
=========================================
  Coverage          ?   95.41%           
=========================================
  Files             ?       27           
  Lines             ?     1266           
  Branches          ?      179           
=========================================
  Hits              ?     1208           
  Misses            ?       58           
  Partials          ?        0
Impacted Files Coverage Δ
src/dialog/DialogManager.ts 96.81% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1197c3d...8c470b2. Read the comment docs.