bessagroup / f3dasm

Framework for Data-Driven Design & Analysis of Structures & Materials (F3DASM)
https://f3dasm.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
111 stars 29 forks source link

ExperimentData method to extract multiple samples by index. #205

Open mpvanderschelling opened 10 months ago

mpvanderschelling commented 10 months ago

Request to add a method to the ExperimentData object to extract multiple ExperimentSample objects by given a iterable of indices.

          Expected method to extract sample by index.

Please check the review comments on the code.

I suggest enriching this method to extract multiple samples (e.g., tuple[ExperimentSample]) from an iterable of indexes or create a new method (e.g., get_experiment_samples(...)) for this purpose. This is a simple improvement that avoids burdening the user with the task of implementing an explicit cycle to extract multiple samples.

Originally posted by @BernardoFerreira in https://github.com/bessagroup/f3dasm/pull/199#pullrequestreview-1701761605