bessagroup / f3dasm

Framework for Data-Driven Design & Analysis of Structures & Materials (F3DASM)
https://f3dasm.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
111 stars 29 forks source link

Change instantiation of Domain object with hydra config #225

Closed mpvanderschelling closed 9 months ago

mpvanderschelling commented 9 months ago

The Problem

Since the Parameter objects are now private (#224), hydra instantiation of a Domain object requires access to a private object. This is not recommended.

Solution

The syntax to instantiate a domain object with a hydra configuration parameter is changed so it requires a type key instead of a _target_ keyword. The documentation and code will be update accordingly