bessagroup / f3dasm

Framework for Data-Driven Design & Analysis of Structures & Materials (F3DASM)
https://f3dasm.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
111 stars 29 forks source link

Optimization requires your domain to have names x0, x1, x2, etc. #240

Closed mpvanderschelling closed 8 months ago

mpvanderschelling commented 9 months ago

Problem

If you have a domain with names x0, x1, x2, etc. optimization can be done. However it gets problematic when you are initializing your domain with other names. This is due to the fact that the from_numpy method of the ExperimentSample class uses these names as defaults.

Possible Solution

Make sure that the domain is also given to the from_numpy method of the ExperimentSample class.

https://github.com/bessagroup/f3dasm/blob/026f29866530760e15e4c068b537e3aadaaf534b/src/f3dasm/_src/experimentdata/experimentsample.py#L60-L85