search

bessagroup / f3dasm

Framework for Data-Driven Design & Analysis of Structures & Materials (F3DASM)
https://f3dasm.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
111 stars 29 forks source link

Bug: sampling with constant variable with float #258

Open mpvanderschelling opened 8 months ago

mpvanderschelling commented 8 months ago

Problem

When sampling from a Domain with a constant variable with a float, the following error is raised:

Traceback (most recent call last):
  File "/home/martin/Documents/scratchbook/try_hydra/main.py", line 10, in <module>
    e = ExperimentData.from_sampling(domain=domain, sampler='random', n_samples=2)
  File "/home/martin/Documents/GitHub/F3DASM/src/f3dasm/_src/experimentdata/experimentdata.py", line 296, in from_sampling
    experimentdata.sample(sampler=sampler, n_samples=n_samples, seed=seed)
  File "/home/martin/Documents/GitHub/F3DASM/src/f3dasm/_src/experimentdata/experimentdata.py", line 1372, in sample
    sample_data: DataTypes = sampler(
  File "/home/martin/Documents/GitHub/F3DASM/src/f3dasm/_src/design/samplers.py", line 157, in __call__
    return self.get_samples()
  File "/home/martin/Documents/GitHub/F3DASM/src/f3dasm/_src/design/samplers.py", line 126, in get_samples
    samples_constant = self._sample_constant(numsamples=numsamples)
  File "/home/martin/Documents/GitHub/F3DASM/src/f3dasm/_src/design/samplers.py", line 163, in _sample_constant
    samples[:, dim] = param.value
ValueError: could not convert string to float: 'test'