bessagroup / rvesimulator

Automated representative volume element simulator via abaqus for material constitutive law discovery
https://bessagroup.github.io/rvesimulator/
MIT License
14 stars 2 forks source link

Methods in `microstructure` module are long and confusing #79

Open mpvanderschelling opened 10 months ago

mpvanderschelling commented 10 months ago

Problem

The functions to create the microstructures are really long. Although they have docstrings, the internal behaviour of the function is complicated and not easy to follow.

Proposed solution

Consider splitting the long methods into smaller methods that do separate things. You can document these smaller methods better and the 'main' method that ties everything together will be more readible.