bessarabov / home-assistant-cards

List of Home Assistant UI cards
https://home-assistant-cards.bessarabov.com
53 stars 13 forks source link

Lots of images for you! 🖼 #2

Closed KTibow closed 3 years ago

KTibow commented 4 years ago

mini-media-player: media-player banner-card: banner-card vacuum-card: vacuum-card Other notes: You should probably remove mod-card (which is a plugin, not a card), layout-card and stack-card (which just create a layout for other cards), and auto-entities (which just passes parameters to a card). Also mind double-checking all images in the database for 492 pixels wideness?

bessarabov commented 4 years ago

Super! Thank you!

I've added images mini-media-player & vacuum-card to this repo — https://github.com/bessarabov/home-assistant-cards/commit/117ad9b75e2848ce792142f0bea7ee0750dad44a (They are already live at https://home-assistant-cards.bessarabov.com/ )

(I've checked the width of that cards and it was expected 492 px)

But I need some time to think about your images for the vertical-stack-in-card and banner-card, and about your proposal to remove some cards.

bessarabov commented 3 years ago

@KTibow KTibow, Thank you again for your work.

I'm not going to add you image for banner card, because it does not represent the common use case of it.

I was thinking about your proposal to remove some cards and I think that now I understand the logic, what I want to see here and what I do not. This repo contains everything that is a card — it means that you can add it to Home Assistant UI, something like:

title: home

views:

  - title: control
    path: default_view
    cards:
      - type: NNNNNN

Even if there is no visible part of the card, this card can be here. layout-card, auto-entities cards can be used in NNNNNN of the above code, so it is ok that they are here (by the way, that things are super useful and popular, I'm sure that they need to be here)

I'm not sure what stack card you are reffering to. There are 2 cards with the word stack in the name:

I'm happy to see both that cards in this repo.

Mod card is a bit special, but it has the ability to be used as a card (https://github.com/thomasloven/lovelace-card-mod#styling-cards-without-an-ha-card-element), so I like to see info about this card in this repo.