besser82 / libxcrypt

Extended crypt library for descrypt, md5crypt, bcrypt, and others
GNU Lesser General Public License v2.1
189 stars 52 forks source link

Update codecov.yml to codecov/codecov-action@v2. #136

Closed zackw closed 3 years ago

zackw commented 3 years ago

codecov-action@v1 is deprecated due to its inextricable coupling with Codecov’s shell-script uploader, which is also deprecated, due to its being an unmaintainable pile of shell script. See https://github.com/codecov/codecov-action/blob/635d4e88ad8c1f75b56277efd9ec186c3359727f/README.md#%EF%B8%8F--deprecration-of-v1 [sic] and https://about.codecov.io/blog/introducing-codecovs-new-uploader/ for gory details.

The new uploader does not support the ‘gcov_executable‘ and ‘gcov_path_exclude‘ parameters yet, so for the time being we go back to preprocessing the coverage data with lcov (as we were doing on Travis).

codecov[bot] commented 3 years ago

Codecov Report

Merging #136 (41886a8) into develop (b321602) will decrease coverage by 1.31%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #136      +/-   ##
===========================================
- Coverage    89.86%   88.55%   -1.32%     
===========================================
  Files           33       32       -1     
  Lines         3413     3607     +194     
  Branches         0      684     +684     
===========================================
+ Hits          3067     3194     +127     
+ Misses         346      228     -118     
- Partials         0      185     +185     
Impacted Files Coverage Δ
lib/crypt-gost-yescrypt.c 69.84% <0.00%> (-12.13%) :arrow_down:
lib/alg-yescrypt-common.c 69.14% <0.00%> (-11.84%) :arrow_down:
lib/crypt-yescrypt.c 76.74% <0.00%> (-10.76%) :arrow_down:
lib/crypt-scrypt.c 72.07% <0.00%> (-10.41%) :arrow_down:
lib/alg-yescrypt-platform.c 83.78% <0.00%> (-9.97%) :arrow_down:
lib/util-get-random-bytes.c 82.85% <0.00%> (-7.15%) :arrow_down:
lib/crypt-des.c 80.71% <0.00%> (-6.66%) :arrow_down:
lib/util-make-failure-token.c 93.75% <0.00%> (-6.25%) :arrow_down:
lib/alg-yescrypt-opt.c 86.07% <0.00%> (-5.69%) :arrow_down:
lib/crypt.c 90.07% <0.00%> (-4.84%) :arrow_down:
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b321602...41886a8. Read the comment docs.

zackw commented 3 years ago

It appears that this also gets us branch tracking back and that's why the apparent coverage loss.

I would like to merge this ahead of #131 to decouple them.